Enable Papi high level stats within the iterate construct #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidsinghal
force-pushed
the
papi_integration
branch
from
04bea56
to
005ca9b
Compare
|
@ulysses4ever any comments on this PR? |
There was a problem hiding this comment.
Is there any chance for:
-
a test showcasing the new flag; I understand numbers won't be stable across machines, but maybe there's a way to check that it's doing anything at all;
-
actual documentation.
I don't know where Gibbon prefers to store docs but the --help message is not sufficient. There should be an example.
I don't feel strongly about the test because, as I mentioned, it may be tricky, but I do feel strongly about the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is experimental and needs review.
The instrumentation is enabled via a compile time command atm.
This is the latest version of PAPI that maintained.
This would need to be installed as a dependency to use --enable-papi